-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-70169] Add comments explaining the absence of breadcrumb items in resources/hudson/PluginManager
#7489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, the sidepanel offers enough functionality to browse between different pages. I don't think we need dedicated breadcrumbs either. |
@timja @NotMyFault Should I rework this PR to add a comment indicating there is no need for breadcrumb at these locations then? |
A comment why no breadcrumbs have been added sounds good to me. |
and me |
resources/hudson/PluginManager
resources/hudson/PluginManager
Can one of you add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
…ms in `resources/hudson/PluginManager` (jenkinsci#7489) * [JENKINS-70169] Add missing breadcrumb items in resources/hudson/PluginManager * better no breadcrumb comment * Replace breadcrumbs by a comment
Extract from #7457
Follow-up of #6912
Initially fixing JENKINS-70169, I've included every missing breadcrumb items I've found by searching for "sidepanel.jelly" in jelly files.
Notes:
I've added
<!-- no need for breadcrumb here -->
as comment in views where adding a breadcrumb item wasn't necessary, let me know if it's preferable to omit them.This doesn't fix missing breadcrumb depending on plugin (ex: Add missing breadcrumbs to job configuration cloudbees-folder-plugin#278)
Testing done
Built and ran Jenkins locally, going on modified pages to check the change.
There is no additional automatic test added for these breadcrumb items.
http://localhost:8080/jenkins/manage/pluginManager/advanced
:http://localhost:8080/jenkins/manage/pluginManager/available
:http://localhost:8080/jenkins/manage/pluginManager/installed
:Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@Wadeck
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).